Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of mixed protocols in Services with type=LoadBalancer #1435

Closed
janosi opened this issue Jan 7, 2020 · 120 comments · Fixed by #3712
Closed

Support of mixed protocols in Services with type=LoadBalancer #1435

janosi opened this issue Jan 7, 2020 · 120 comments · Fixed by #3712
Assignees
@bridgetkromhout @thockin
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Obsolete: SIG-Network KEPs (see https...
Milestone
v1.28

Comments

@janosi
Copy link
Contributor

janosi commented Jan 7, 2020 •
edited by thockin

Enhancement Description

  • One-line enhancement description (can be used as a release note): This feature enables the creation of a LoadBalancer Service that has different port definitions with different protocols.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1435-mixed-protocol-lb
  • Primary contact (assignee): Laszlo Janosi (@janosi)
  • Responsible SIGs: Network, Cloud Provider
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.20
    • Beta release target 1.24
    • Stable release target 1.26

KEP document: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200103-mixed-protocol-lb.md

GA k/k PR in v1.26: kubernetes/kubernetes#112895

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 7, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 7, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 7, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 7, 2020

Original issue: kubernetes/kubernetes#23880

@janosi janosi mentioned this issue Jan 8, 2020
Merged
@helayoty
Copy link
Member

Hey there @janosi -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@janosi
Copy link
Contributor Author

janosi commented Jan 17, 2020

Hello @helayoty, thank you for your guidance! I really hope we can make it in 1.18. Let's hope we can have an agreed design plan via the KEP on time, and then the implementation can be finished.

The relevant PR in k/k: kubernetes/kubernetes#75831

@helayoty
Copy link
Member

helayoty commented Jan 17, 2020 •
edited

Thanks, @janosi for the update. Would you please include the KEP PR if any?

@helayoty
Copy link
Member

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
@helayoty helayoty added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2020
@janosi
Copy link
Contributor Author

janosi commented Jan 18, 2020

Would you please include the KEP PR if any?

@helayoty Yes, of course. I added the ref to the KEP PR to the initial description of this issue.

@kikisdeliveryservice
Copy link
Member

Hi @janosi as a reminder: today is the deadline for Enhancements Freeze for 1.18. If you need any help from the release team's side please let us know.

@janosi
Copy link
Contributor Author

janosi commented Jan 28, 2020

@kikisdeliveryservice Yeah, thank you! Actually I wait for a go/no go statement on the KEP PR from the SIG Network members @thockin @caseydavenport @andrewsykim

@jeremyrickard
Copy link
Contributor

Hey @janosi, unfortunately since the KEP didn't merge before enhancement freeze, we're going to need to remove it from the milestone. If you can get the KEP merged, you can file an Exception Request and we can add it back to the milestone.

@jeremyrickard
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Jan 29, 2020
@jeremyrickard jeremyrickard added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 29, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@palnabarun
Copy link
Member

Hi @janosi -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@janosi
Copy link
Contributor Author

janosi commented Apr 30, 2020

Hi @palnabarun , The situation is same here as with the SCTP feature. I do not know what will happen. The KEP waits for more comments as there was an alternative proposal for the control of the solution. That is the last update that happened 28 days ago.

@thockin @andrewsykim

@kenperkins
Copy link

What's needed here? This appears to have stalled; I'd love to help if there's anything I can do.

@palnabarun
Copy link
Member

@janosi -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@adampl adampl mentioned this issue Jun 24, 2020
Closed
@janosi
Copy link
Contributor Author

janosi commented Aug 15, 2020

PR: kubernetes/kubernetes#94028

@Atharva-Shinde
Copy link
Contributor

Hey @janosi @thockin @bridgetkromhout 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up.
Thanks :)

@katmutua
Copy link
Member

katmutua commented Nov 1, 2022 •
edited

Hello @janosi ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@janosi
Copy link
Contributor Author

janosi commented Nov 2, 2022

@Atharva-Shinde The only k/k PR is the kubernetes/kubernetes#112895
@katmutua I started working on the documentation, too.

@janosi janosi mentioned this issue Nov 2, 2022
Merged
@janosi
Copy link
Contributor Author

janosi commented Nov 2, 2022

@katmutua The doc PR is kubernetes/website#37676

@janosi
Copy link
Contributor Author

janosi commented Nov 3, 2022

@Atharva-Shinde k/k PR kubernetes/kubernetes#112895 has been merged.

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Nov 3, 2022
@marosset
Copy link
Contributor

Hi @janosi - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1435-mixed-protocol-lb/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 13, 2022
@thockin thockin modified the milestones: v1.26, v1.28 Jan 5, 2023
@bridgetkromhout bridgetkromhout mentioned this issue Jan 5, 2023
Merged
aojea added a commit to aojea/cloud-provider-gcp that referenced this issue Feb 22, 2023
@aojea
unsupported loadbalancres with mixed protocols
447fa10 
The external cloud provider controller for loadbaancers does not
support Services with different protocols and most probably it
will never support them, since most of the functionality and
development for loadbalancers is being done in the ingress-gce
project.

Ref: kubernetes/enhancements#1435
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076
@aojea aojea mentioned this issue Feb 22, 2023
Merged
aojea added a commit to aojea/cloud-provider-gcp that referenced this issue Mar 15, 2023
@aojea
unsupported loadbalancres with mixed protocols
8f23b20 
The external cloud provider controller for loadbaancers does not
support Services with different protocols and most probably it
will never support them, since most of the functionality and
development for loadbalancers is being done in the ingress-gce
project.

Ref: kubernetes/enhancements#1435
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076
aojea added a commit to aojea/cloud-provider-gcp that referenced this issue Mar 15, 2023
@aojea
unsupported loadbalancres with mixed protocols
c4a6f73 
The external cloud provider controller for loadbaancers does not
support Services with different protocols and most probably it
will never support them, since most of the functionality and
development for loadbalancers is being done in the ingress-gce
project.

Ref: kubernetes/enhancements#1435
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076
@rg0now rg0now mentioned this issue Apr 8, 2023
Closed
@thockin
Copy link
Member

thockin commented Apr 27, 2023

NEXT: Remove gate in 1.28

@thockin thockin reopened this Apr 27, 2023
Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) automation moved this from GA (merged, gate not removed) to New, not evaluated Apr 27, 2023
@thockin thockin mentioned this issue Apr 27, 2023
Merged
@thockin thockin moved this from New, not evaluated to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Apr 27, 2023
@thockin thockin moved this from GA (merged, gate not removed) to DONE (GA, merged, gate removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Apr 28, 2023
@thockin
Copy link
Member

thockin commented Apr 28, 2023

DONE

@thockin thockin closed this as completed Apr 28, 2023
aojea added a commit to aojea/cloud-provider-gcp that referenced this issue May 10, 2023
@aojea
unsupported loadbalancres with mixed protocols
67c484c 
The external cloud provider controller for loadbaancers does not
support Services with different protocols and most probably it
will never support them, since most of the functionality and
development for loadbalancers is being done in the ingress-gce
project.

Ref: kubernetes/enhancements#1435
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076
aojea added a commit to aojea/cloud-provider-gcp that referenced this issue May 10, 2023
@aojea
unsupported loadbalancres with mixed protocols
56834cc 
The external cloud provider controller for loadbaancers does not
support Services with different protocols and most probably it
will never support them, since most of the functionality and
development for loadbalancers is being done in the ingress-gce
project.

Ref: kubernetes/enhancements#1435
Change-Id: Iaec2ee17ccdc7c55c613189d8a3708b5a62d5076
@Sporesirius Sporesirius mentioned this issue May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridgetkromhout bridgetkromhout

@thockin thockin

Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
1.26 Enhancements Tracking
Status: Graduating
Obsolete: SIG-Network KEPs (see https...
DONE (GA, merged, gate removed)
Milestone
v1.28