/sig network

Hi Andrew - I'm pretty interested in this feature and started looking at what needs to change following keps/sig-network/2086

I'll try to get a PR up in the next few days, it will be my first contribution to k8s so I'm probably going to be make blunders here and there :)

Let me know if this works for you, unless you already had planned working on this. Thanks!

@rmanyari thanks for reaching out, I had actually started some work on this feature already which I have checked in a local branch. I would love and appreciate help reviewing the upcoming PR though

Fantastic! Just pushed a commit to my remote with the API changes: rmanyari/kubernetes@11cbdf5

Will keep poking at the actual change later tonight and I still need to read the contributions guidelines and sign the CLA and all that good stuff.

Sorry in case I didn't make my last comment clear, I meant that I started to work on this already and I'm planning to open a PR soon. But I would appreciate your help reviewing my upcoming PR :)

Ah, got it! Sure, I can help reviewing/testing. I'll continue with my little experiment anyway just to see how far/right I would've implemented this.

Hi @andrewsykim, 1.21 Enhancements Lead here.

For the enhancement to be included in the milestone, it must meet the following criteria:

• [DONE] The KEP must be merged in an implementable state
• [DONE] The KEP must have test plans
• [DONE] The KEP must have graduation criteria
• The KEP must have a production readiness review

Looks like KEP does include the questionnaires, but it also requires a file under https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/sig-network. Please make sure to create one before the enhancements freeze.

Thank you!

Hi @andrewsykim

Enhancements Freeze is tomorrow, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2166 [Update] based on #2086 (comment) PR #2441). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

• [DONE] The KEP must be merged in an implementable state
• [DONE] The KEP must have test plans
• [DONE] The KEP must have graduation criteria
• [IN PROGRESS] The KEP must have a production readiness review

@annajung KEP update proposed in #2166 is adopted in the implementation: kubernetes/kubernetes#96600

#2441 adds the PRR.

With PR #2441 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
  • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

Hey @andrewsykim

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

PR for this is being discusses and reviewed. Not dead yet.

kubernetes/kubernetes#96600

Reopening the issue since all enhancement issues must be left open until enhancement graduates to stable and KEP is marked as implemented.

Also will mark this as code complete for the upcoming code freeze. If this is a mistake, please link other code PRs and ping me to notify. thank you!

Hello @andrewsykim , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

Hi @andrewsykim, today is the Doc Placeholder PR deadline for the 1.21 release. If this enhancement needs new or updated docs for the 1.21 release, please make a PR to the dev-1.21 branch in the k/website repo. The PR can be a placeholder.

Quick reminder - Enhancement freeze is about a week away. If you are still looking to get this enhancement into v1.26, please plan to get #3509 merged up.

With #3509 merged up, this is all set for enhancements freeze. Thanks!

@andrewsykim Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

Hi @andrewsykim @maplain @MaxRenaud 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, I could not locate any open k/k PRs. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

Hi @andrewsykim @maplain @MaxRenaud 👋 This enhancement is marked as Needs Docs for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Hey @andrewsykim @maplain @MaxRenaud,

As the Code freeze is just a day away, just wanted to confirm if there are no open PRs in the K/K repo or any repo in general for this enhancement? So that the enhancement can be marked tracked.

I synced with Andrew and we are good to mark as tracked.

I synced with Andrew and we are good to mark as tracked.

Marked as tracked.

Hey @andrewsykim, @maplain, and @MaxRenaud, this is a reminder to open a PR against dev-1.26 branch in the k/website repo by November 9. This PR can be just a placeholder at this time.

Hey again @andrewsykim, @maplain, and @MaxRenaud 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday, November 15th, 2022. Thank you!

Hey @andrewsykim, @maplain, and @MaxRenaud 👋 The k/website PR deadline is tomorrow, Tuesday, November 15th, 2022. For information about creating the PR, please take a look at Documenting for a release - PR Ready for Review. Thanks!

Thanks for the poke, I will check out the docs later today. IIRC most of the docs were written for Beta so it may be just a matter of updating the milstones in the docs from Beta -> GA

doc: kubernetes/website#37912

Hi @andrewsykim - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/2086-service-internal-traffic-policy/kep.yaml setting the status to implemented and then close this issue.
Thanks!

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@andrewsykim can you update the main issue here with release numbers?

NEXT: Remove gate in 1.28

DONE