Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor Persistent Volume Reclaim Policy #2680

Merged
merged 1 commit into from Sep 8, 2021
Merged

Honor Persistent Volume Reclaim Policy #2680

merged 1 commit into from Sep 8, 2021

Conversation

deepakkinni
Copy link
Member

@deepakkinni deepakkinni commented May 6, 2021 •
edited by xing-yang

Prevent volumes from being leaked by honoring the PV delete reclaim policy if for a bound PV-PVC pair, the PV is deleted first followed by deleting the PVC.

Enhancement issue: #2644

Signed-off-by: Deepak Kinni dkinni@vmware.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @deepakkinni!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @deepakkinni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2021
@xing-yang xing-yang self-assigned this May 6, 2021
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@xing-yang
Copy link
Contributor

/assign @jsafrane

@deepakkinni deepakkinni changed the title [WIP] Honor Persistent Volume Reclaim Policy Honor Persistent Volume Reclaim Policy May 6, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2021
@deepakkinni
Copy link
Member Author

/test pull-enhancements-verify

ehashman
ehashman requested changes May 6, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
ehashman
ehashman approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for PRR

This still needs approval from the SIG Storage Leads.

@xing-yang xing-yang mentioned this pull request May 14, 2021
Open
4 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2021
@xing-yang
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2021
@xing-yang xing-yang added this to the v1.23 milestone Aug 26, 2021
jsafrane
jsafrane reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@jsafrane jsafrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly checked the KEP, it goes the right direction. There are still some rough edges, but I think all of them can be solved. I still need to check what's ctrl.addFinalizer in the external provisioner - is it the same thing as the new deletion protection finalizer? Do we need both then?

keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
keps/sig-storage/2644-honor-pv-reclaim-policy/README.md Outdated Show resolved Hide resolved
@xing-yang xing-yang force-pushed the issue2644 branch 2 times, most recently from bf620e3 to 0f4393c Compare September 2, 2021 16:52
@jsafrane
Copy link
Member

jsafrane commented Sep 8, 2021

/approve
From sig-storage POV. Will lgtm before KEP deadline if there are no other comments.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, ehashman, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@xing-yang
Honor Persistent Volume Reclaim Policy
ef508ca 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@jsafrane
Copy link
Member

jsafrane commented Sep 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit eff73b4 into kubernetes:master Sep 8, 2021
@deepakkinni deepakkinni mentioned this pull request Dec 6, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@jsafrane jsafrane jsafrane left review comments

@ehashman ehashman ehashman approved these changes

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deepakkinni @k8s-ci-robot @xing-yang @k8s-triage-robot @jsafrane @ehashman