Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve Service IP Ranges For Dynamic and Static IP Allocation #3070

Closed
aojea opened this issue Dec 2, 2021 · 37 comments · Fixed by aojea/enhancements#2 or #3708
Closed

Reserve Service IP Ranges For Dynamic and Static IP Allocation #3070

aojea opened this issue Dec 2, 2021 · 37 comments · Fixed by aojea/enhancements#2 or #3708
Assignees
@aojea
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Obsolete: SIG-Network KEPs (see https...
Milestone
v1.28

Comments

@aojea
Copy link
Member

aojea commented Dec 2, 2021 •
edited

Enhancement Description

This feature went to GA in 1.26 kubernetes/kubernetes#112163 🥳

xref: kubernetes/kubernetes#106792
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 2, 2021
This was referenced Dec 2, 2021
Merged
Merged
@pacoxu
Copy link
Member

pacoxu commented Jan 6, 2022

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2022
@thockin thockin added this to the v1.24 milestone Jan 6, 2022
@thockin thockin moved this from New, not evaluated to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jan 6, 2022
@aojea aojea changed the title Reserved range within service CIDR wherein automatically assigned IPs will not be chosen Reserve Service IP Range For Dynamic and Static IP Allocation Jan 7, 2022
@aojea aojea changed the title Reserve Service IP Range For Dynamic and Static IP Allocation Reserve Service IP Ranges For Dynamic and Static IP Allocation Jan 7, 2022
@hosseinsalahi
Copy link

Hello @aojea

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date.
Thanks!

@nate-double-u
Copy link

Hi @aojea 👋 1.24 Docs lead here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, March 31st, 2022 @ 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 6, 2022
This was referenced Mar 18, 2022
Closed
Merged
@valaparthvi
Copy link

Hi @aojea 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@hosseinsalahi
Copy link

hosseinsalahi commented Mar 21, 2022 •
edited

Hello @aojea

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as tracked.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above.
Thank you so much!

@aojea
Copy link
Member Author

aojea commented Mar 21, 2022

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much

@encodeflush those 2 PRs are the implementation and the docs,

@valaparthvi
Copy link

Hi @aojea wave 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

Hi @aojea, can you please add a placeholder PR for this feature in https://github.com/kubernetes/website by March 30, that is our extended deadline for feature blog freeze?

Example of a feature blog PR: kubernetes/website#30538
Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

@aojea
Copy link
Member Author

aojea commented Mar 29, 2022

@valaparthvi https://github.com/kubernetes/website/pull/32606/files

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Alpha gated (code is merged) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Mar 29, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
@Priyankasaggu11929
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone May 10, 2022
@aojea aojea mentioned this issue Jun 7, 2022
Merged
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 9, 2022
@Priyankasaggu11929
Copy link
Member

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 9, 2022
@ruheenaansari34
Copy link

Hello @aojea 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • update the merged kep.yaml to reflect latest stage & milestone information.
  • add a PRR approval for stage stable that has been completed and have it merged into k/enhancements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@aojea aojea mentioned this issue Oct 4, 2022
Closed
@aojea
Copy link
Member Author

aojea commented Oct 4, 2022

Thanks @ruheenaansari34 for the heads up, sent PR to fix it
#3578

@aojea aojea mentioned this issue Oct 5, 2022
Merged
@rhockenbury
Copy link

With #3583 merged, we have this marked as tracked for v1.26. Thanks.

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Oct 14, 2022
@mickeyboxell
Copy link

@aojea Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

@aojea
Copy link
Member Author

aojea commented Oct 21, 2022

@aojea Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

Thanks for the remindes, submitted
kubernetes/website#37432 @mickeyboxell

@Atharva-Shinde
Copy link
Contributor

Hey @aojea 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to this enhancement are linked in the issue description above(for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

As always, we are here to help should questions come up.
Thanks :)

@Atharva-Shinde
Copy link
Contributor

Hey @aojea 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PRs merged before the code-freeze. Could you also please update the Issue Description with related code PRs :)

@aojea
Copy link
Member Author

aojea commented Nov 7, 2022

Done, thanks for the heads up

@rhockenbury
Copy link

We have this marked as tracked for code freeze.

@marosset
Copy link
Contributor

Hi @aojea - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3070-reserved-service-ip-range/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 12, 2022
@aojea
Copy link
Member Author

aojea commented Dec 31, 2022

sent #3707 for setting status to implemented

This was referenced Dec 31, 2022
Closed
Merged
@aojea aojea mentioned this issue Dec 31, 2022
Merged
@thockin thockin modified the milestones: v1.26, v1.28 Jan 5, 2023
@thockin
Copy link
Member

thockin commented Apr 27, 2023

NEXT: Remove gate in 1.28

@thockin thockin reopened this Apr 27, 2023
Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) automation moved this from GA (merged, gate not removed) to New, not evaluated Apr 27, 2023
@thockin thockin mentioned this issue Apr 27, 2023
Merged
@thockin thockin moved this from New, not evaluated to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Apr 27, 2023
@thockin thockin moved this from GA (merged, gate not removed) to DONE (GA, merged, gate removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Apr 28, 2023
@thockin
Copy link
Member

thockin commented Apr 28, 2023

DONE

@thockin thockin closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aojea aojea

Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
1.26 Enhancements Tracking
Status: Graduating
Obsolete: SIG-Network KEPs (see https...
DONE (GA, merged, gate removed)
Milestone
v1.28