New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transient node predicates from KCCM's service controller #3458
Comments
/sig network |
Punting to 1.27 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/label lead-opted-in |
/retitle Remove transient node predicates from KCCM's service controller |
@thockin @alexanderConstantinescu can one of you confirm that this targeting |
Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation? |
yes please - this one doesn't have APi so doesn't need an alpha |
Thanks @thockin @alexanderConstantinescu |
Once #3835 merges this enhancement will be ready for inclusion in v1.27 |
With #3835 merged this enhancement is ready to be |
Hi @thockin 👋,
Please let me know what PRs in k/k I should be tracking for this KEP. |
Pinging this after sig-net - let's decide if this moves to GA in 1.30 |
I'll let it soak at least one release more kubernetes/kubernetes#121116, WDYT @alexanderConstantinescu , just to get signal, these things take some time to detect |
I am fine with this. I'm filing a PR updating the enhancement with a stable milestone set for 1.30 |
1.30 is next - did you mean 31? |
I meant 1.30. My understanding is: if we want to "soak for one more release" then we extend the current milestone by one release. This feature was marked @aojea : did you mean that we should go to stable in 1.31? |
For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now. I'm OK if we want to let it ride one more, but I am not sure it's buying us anything |
+1 I'll let Antonio decide, following how strongly he feels about it |
not really, major providers have to revendor and use to take some time to pick up these changes, all cloud provider code moved to external cloud providers, and it was beta but we had a fix in 1.29 with backports kubernetes/kubernetes@2032b74 |
although, we are going to remove the cloud providers tests this release (most probably), so it will be useless to get it another release more, @alexanderConstantinescu go ahead and GA this then |
Also, from the original bug: """ It was about a regression on 1.26 or when the gate was disabled. |
oh, my fault, sorry, I skipped that super important detail 😓 |
Hello @alexanderConstantinescu and @thockin 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
@salehsedghpour : I made a mistake in the last release and got a prr-review for Stable, but forgot to update the code afterwards. In this release we're only updating the code and the prr-review file already exists, see: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3458.yaml Is this fine? |
Yes, thanks for the clarification. With this information, this enhancements is now |
Hi @alexanderConstantinescu and @thockin 👋, 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Hi @thockin, 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
Hey again @alexanderConstantinescu and @thockin 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as Please let me know if there are other PRs in k/k we should be tracking for this KEP. |
@salehsedghpour : this is the only PR which was needed for this release: kubernetes/kubernetes#122961 - the implementation was done a while ago. This PR just promotes the feature to stable |
@alexanderConstantinescu thanks for clarification. As kubernetes/kubernetes#122961 is already merged, this can now be marked as May you please also make sure that this PR is added to issue description as well? |
@alexanderConstantinescu, Enhancements team here! |
Hi @salehsedghpour : just to confirm: this feature is going GA in 1.30, so we will remove the feature gate in 1.31. Should I mark it |
Thanks @alexanderConstantinescu, with this please consider marking it as |
Will do! |
@alexanderConstantinescu can you update the checklist in the initial comment with the current state? (Like, it currently shows that alpha is incomplete, but my understanding from reading the comments here is that it's actually GA.) |
I've updated the description to this PR, should be up-to-date now. |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: