Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from SPDY to WebSockets #4006

Open
8 tasks done
seans3 opened this issue May 15, 2023 · 42 comments
Open
8 tasks done

Transition from SPDY to WebSockets #4006

seans3 opened this issue May 15, 2023 · 42 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@seans3
Copy link
Contributor

seans3 commented May 15, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@seans3 seans3 self-assigned this May 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 15, 2023
@seans3
Copy link
Contributor Author

seans3 commented May 15, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2023
@seans3
Copy link
Contributor Author

seans3 commented May 15, 2023

/sig cli
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 15, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 2, 2023

/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 2, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 2, 2023
@salehsedghpour
Copy link
Contributor

Hello @seans3 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@seans3
Copy link
Contributor Author

seans3 commented Jun 9, 2023

@salehsedghpour

Hello. Since the PRR reviewer @deads2k approved the KEP and since the KEP has been merged, I believe this KEP is now ready for v1.28. Please let me know if there are any other tasks needed for this release.

Thanks.

@katcosgrove
Copy link

Hello @seans3! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @seans3 , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@salehsedghpour
Copy link
Contributor

Hey again @seans3 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hello @seans3 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

@sanchita-07
Copy link
Member

Hello @seans3 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, please update the latest-milestone to v1.29 and the alpha milestone to 1.29 in the kep.yaml.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

Thank you!

@liggitt
Copy link
Member

liggitt commented Oct 2, 2023

  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.

that doesn't really make sense... the KEP is still in alpha and is remaining implementable for 1.29 in alpha, not completing

@jpbetz
Copy link
Contributor

jpbetz commented Oct 2, 2023

/label lead-opted-in
(for 1.29)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 19, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jan 19, 2024

/milestone v1.30

@k8s-ci-robot
Copy link
Contributor

@seans3: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Jan 21, 2024

Hello @seans3 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The stage should be updated to beta in the kep.yaml file.
  • The production readiness review should be completed and updated with the information for the targeting stage beta.
  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.
  • Make sure the milestone is updated to v1.30 using /milestone v1.30 command.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@deads2k
Copy link
Contributor

deads2k commented Feb 2, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 5, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 6, 2024

@seans3 the template of this KEP needs to be refreshed ("KEP readme using the latest template has been merged into the k/enhancements repo.")

@seans3
Copy link
Contributor Author

seans3 commented Feb 6, 2024

Sean Sullivan the template of this KEP needs to be refreshed ("KEP readme using the latest template has been merged into the k/enhancements repo.")

Done.

@salehsedghpour
Copy link
Contributor

Hello @seans3 👋, Enhancements team here.

With the recent changes in #4416, everything seems to be fine. There is only one unanswered question in the Production Readiness Review Questionnaire.

Please make sure to merge this PR before enhancements freeze. Thank you.

@salehsedghpour
Copy link
Contributor

With #4416 being merged, this enhancement is now marked as tracked for enhancement freeze.

@Princesso
Copy link

Hello @seans3, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@kcmartin
Copy link

Hi @seans3,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@seans3
Copy link
Contributor Author

seans3 commented Feb 22, 2024

Hello Sean Sullivan, 👋 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

I have added the following PR (which updates the feature flags for this functionality). Please let me know what you think: kubernetes/website#45270

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 22, 2024

Hey again @seans3 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@seans3
Copy link
Contributor Author

seans3 commented Feb 29, 2024

Hey again Sean Sullivan 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

@salehsedghpour You are correct about the third PR. It (#120889) has been closed in favor of the first PR (#123413). Thanks.

@salehsedghpour
Copy link
Contributor

@seans3 Thanks for clarification. With all PR's being merged, this can now be marked as tracked for code freeze.

saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Mar 25, 2024
The latest Kubernetes beta supports using websockets for port-forward.
We now introduce a similar option to `attach` and `exec` to be able to
select the new transport.

See: kubernetes/enhancements#4006

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Mar 26, 2024
The latest Kubernetes beta supports using websockets for port-forward.
We now introduce a similar option to `attach` and `exec` to be able to
select the new transport.

See: kubernetes/enhancements#4006

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Removed from Milestone
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Status: In Progress
Development

No branches or pull requests