New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubelet Support for Image Filesystem being split. #4191
Comments
/sig node |
/stage alpha |
/assign |
Hello @kannon92 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP #4198 seems to take care of everything. Please make sure that the PR is merged in time. Will move the KEP to The status of this enhancement is marked as |
Hi @kannon92, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like #4198 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks! |
Changes were merged so we hopefully should be good. |
With KEP PR #4198 approved, the enhancement is ready for the enhancements freeze. The status is now marked as |
Hey there @kannon92! 👋, v1.29 Docs Lead here. |
Hi again @kannon92! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you! |
This first alpha release won’t have any corresponding doc changes yet. |
Hi @kannon92 👋 from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release. |
Hey again @kannon92 👋 v1.29 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 . Here's where this enhancement currently stands:
The status of this KEP is currently As always, we are here to help if any questions come up. Thanks! |
With kubernetes/kubernetes#120616 this is now marked as |
/remove-label lead-opted-in |
Update for 1.30: We are making good progress on the ecosystem (critools, crio and cadvisor PRs were merged). We need a cadvisor release to close out this implementation for alpha. Will update kubernetes/kubernetes#122438 to include cadvisor release when its available. I have been working on e2e tests for image filesystem and I have started writing e2e configs for split disk. |
Hello 👋 1.30 Enhancements Lead here, I'm closing milestone 1.29 now, /milestone clear |
@mrunalp @SergeyKanzhelev could you add a milestone and opt in label for this feature? I’ll be working on advisor bump and e2e tests in 1.30 |
/milestone v1.30 |
Hello @kannon92 👋, Enhancements team here. Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to complete the following:
The status of this enhancement is marked as |
We don't need a PRR for this one. It is still staying in alpha and we had a brief one in the last release. |
Main goal for this next stage is to get some dependencies changes and add e2e tests. So nothing changed from first PRR review. |
Ah, ok! Sounds good - I'll mark this as tracked for enhancements freeze! Thanks for your quick response. |
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀 |
Hello @kannon92 👋, 1.30 Docs Lead here. Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. |
Hi @kannon92 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
Hey again @kannon92 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hey @kannon92 - looks like the two above PRs merged! I'm seeing that kubernetes/kubernetes#123518 has been added to the issue... code freeze is ~6 hours away. Do you think it will merge in time? |
This is for test freeze. So I don’t think it should be tracked in code freeze. |
Hello @kannon92 👋 , Enhancements team here. With all the implementation(code related) PRs merged as per the issue description:
This enhancement is now marked as |
We hit a blocker with adding tests. It turns out that there is a fix in container/storage which crio uses for this work. We are waiting for podman 5.0 to be released and then we can update crio to use the latest storage changes. We want to kick off a branch for 1.30 that does not include podman 5.0 changes so we are going to wait until 1.31 to get the e2e tests working. So I will not be documenting this feature in a blog post because there is still some risk with the feature and I do not want to advertise the feature yet. Kubelet changes are good as is. This is mainly a problem in the container runtime so we do not need any revert or anything. |
Enhancement Description
One-line enhancement description (can be used as a release note): Kubelet can support ImageFilesystem being separated between writeable and read-only layer
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4191-split-image-filesystem/README.md
Discussion Link: Garbage Collection Working group.
Primary contact (assignee): @kannon92
Responsible SIGs: sig-node
Enhancement target (which target equals to which milestone):
Alpha - CRI Updates
k/enhancements
) update PR(s):k/k
) update PR(s):Alpha - container runtime support and ecosystem
Code (
crio/crio
):CAdvisor (
google/cadvisor
):CRITools (
kubernetes-sigs/critools
):Kubernetes (
kubernetes/kubernetes
):Testing
Split disk crio setup test-infra#31502
WIP: testing split disk e2e tests kubernetes#123518
Docs (
k/website
) update PR(s):Nice to haves:
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: