Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Support for Image Filesystem being split. #4191

Open
6 of 10 tasks
kannon92 opened this issue Sep 6, 2023 · 30 comments
Open
6 of 10 tasks

Kubelet Support for Image Filesystem being split. #4191

kannon92 opened this issue Sep 6, 2023 · 30 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@kannon92
Copy link
Contributor

kannon92 commented Sep 6, 2023

Enhancement Description

Nice to haves:

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 6, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Sep 7, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2023
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@kannon92
Copy link
Contributor Author

/assign

@sreeram-venkitesh
Copy link
Member

Hello @kannon92 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP #4198 seems to take care of everything. Please make sure that the PR is merged in time. Will move the KEP to tracked for enhancement freeze once everything is merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sreeram-venkitesh
Copy link
Member

Hi @kannon92, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like #4198 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks!

@kannon92
Copy link
Contributor Author

kannon92 commented Oct 5, 2023

Changes were merged so we hopefully should be good.

@npolshakova
Copy link

With KEP PR #4198 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

@katcosgrove
Copy link

Hey there @kannon92! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@katcosgrove
Copy link

Hi again @kannon92! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@kannon92
Copy link
Contributor Author

This first alpha release won’t have any corresponding doc changes yet.

@James-Quigley
Copy link

Hi @kannon92 👋 from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release.
If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)
Here's the 1.29 Calendar

@sreeram-venkitesh
Copy link
Member

Hey again @kannon92 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

The status of this KEP is currently at risk for Code Freeze. From what I understand, kubernetes/kubernetes#120914 and kubernetes/kubernetes#120616 are the code PRs that is planned for the v1.29 release. Please make sure that kubernetes/kubernetes#120616 is merged in time for the code freeze.

As always, we are here to help if any questions come up. Thanks!

@npolshakova
Copy link

With kubernetes/kubernetes#120616 this is now marked as tracked for code freeze for 1.29! 🚀

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2024

Update for 1.30:

We are making good progress on the ecosystem (critools, crio and cadvisor PRs were merged). We need a cadvisor release to close out this implementation for alpha.

Will update kubernetes/kubernetes#122438 to include cadvisor release when its available.

I have been working on e2e tests for image filesystem and I have started writing e2e configs for split disk.

@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 2, 2024

@mrunalp @SergeyKanzhelev could you add a milestone and opt in label for this feature?

I’ll be working on advisor bump and e2e tests in 1.30

@mrunalp
Copy link
Contributor

mrunalp commented Feb 7, 2024

/milestone v1.30
/stage alpha
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 7, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 7, 2024
@tjons
Copy link

tjons commented Feb 8, 2024

Hello @kannon92 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kannon92
Copy link
Contributor Author

kannon92 commented Feb 8, 2024

We don't need a PRR for this one. It is still staying in alpha and we had a brief one in the last release.

@kannon92
Copy link
Contributor Author

kannon92 commented Feb 8, 2024

Main goal for this next stage is to get some dependencies changes and add e2e tests. So nothing changed from first PRR review.

@tjons
Copy link

tjons commented Feb 8, 2024

Ah, ok! Sounds good - I'll mark this as tracked for enhancements freeze! Thanks for your quick response.

@tjons
Copy link

tjons commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@drewhagen
Copy link
Member

Hello @kannon92 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@fkautz
Copy link
Member

fkautz commented Feb 16, 2024

Hi @kannon92

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@tjons
Copy link

tjons commented Feb 25, 2024

Hey again @kannon92 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons
Copy link

tjons commented Mar 6, 2024

Hey @kannon92 - looks like the two above PRs merged! I'm seeing that kubernetes/kubernetes#123518 has been added to the issue... code freeze is ~6 hours away. Do you think it will merge in time?

@kannon92
Copy link
Contributor Author

kannon92 commented Mar 6, 2024

This is for test freeze. So I don’t think it should be tracked in code freeze.

@salehsedghpour
Copy link
Contributor

Hello @kannon92 👋 , Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

@kannon92
Copy link
Contributor Author

We hit a blocker with adding tests. It turns out that there is a fix in container/storage which crio uses for this work.

We are waiting for podman 5.0 to be released and then we can update crio to use the latest storage changes. We want to kick off a branch for 1.30 that does not include podman 5.0 changes so we are going to wait until 1.31 to get the e2e tests working.

So I will not be documenting this feature in a blog post because there is still some risk with the feature and I do not want to advertise the feature yet.

Kubelet changes are good as is. This is mainly a problem in the container runtime so we do not need any revert or anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked for Code Freeze
Status: Tracked for Code Freeze
Development

No branches or pull requests