Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet image GC after a maximum age #4210

Open
6 of 8 tasks
haircommander opened this issue Sep 14, 2023 · 28 comments
Open
6 of 8 tasks

kubelet image GC after a maximum age #4210

haircommander opened this issue Sep 14, 2023 · 28 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@haircommander
Copy link
Contributor

haircommander commented Sep 14, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 14, 2023
@haircommander
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2023
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@dchen1107
Copy link
Member

cc/ @bsdnet to help reviewing.

@npolshakova
Copy link

Hello @haircommander 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

It looks like https://github.com/kubernetes/enhancements/pull/4211/files will address most of these issues when it merges in!

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kannon92
Copy link
Contributor

/assign @haircommander

@npolshakova
Copy link

Hi @haircommander, just checking in once more as we approach the 1.29 enhancement freeze deadline this week on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.

It looks like #4211 will address most of the requirements when it merges. Let me know if I missed anything. Thanks!

@npolshakova
Copy link

With KEP PR #4211 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

@katcosgrove
Copy link

Hey there @haircommander! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@pacoxu
Copy link
Member

pacoxu commented Oct 17, 2023

containerd/containerd#9022 adds support for image expiration in GC, which is a similar concept. But this is a containerd v2.0 feature.

@katcosgrove
Copy link

Hi again @haircommander! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@haircommander
Copy link
Contributor Author

thanks for the reminder @katcosgrove I've opened the draft here kubernetes/website#43544

@npolshakova
Copy link

Hey again @haircommander 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

This KEP is currently marked as at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@kannon92
Copy link
Contributor

@haircommander can you update this issue with the relevant PRs for alpha?

kubernetes/kubernetes#121275 should be added to this description.

#4211 is another that should be added.

@a-mccarthy
Copy link

Hi @haircommander, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@npolshakova
Copy link

Thanks for updating the issue description. This is now tracked for code freeze for 1.29! 🚀

@sftim
Copy link
Contributor

sftim commented Nov 14, 2023

SIG Node, don't forget to document the changes here. SIG Docs (and SIG Release's release docs subteam) can help you understand what to do.

@haircommander
Copy link
Contributor Author

I updated the PR!

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@SergeyKanzhelev
Copy link
Member

/stage beta
/milestone v1.30

(as per #4426)

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 23, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 2, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The production readiness review should be completed. One question appears partially unanswered.
  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@celestehorgan
Copy link

Hi @pnbrown!

Can you:

  • Update your issue description to include a checklist for the beta release in 1.30?

Also, please open a docs placeholder PR by the end of the week <3. Even if you aren't making any functionality changes in this release, remember to update your feature flags from alpha to beta! ✨

@pnbrown
Copy link

pnbrown commented Feb 14, 2024

Hi @celestehorgan, I'm just on the Enhancements team. @haircommander is the owner.

@Checksumz
Copy link

Hi @haircommander ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@pnbrown
Copy link

pnbrown commented Feb 29, 2024

Hey again @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@AnishShah
Copy link

AnishShah commented Mar 13, 2024

I was initially confused by the MinAge and ImageGCMaxAge config flags. I had to read the docs and api comments to understand better. Here's a clearer breakdown to help others:

  1. MinAge: This truly is the minimum age (time since it was first pulled) before the kubelet considers garbage collecting an image.

  2. ImageGCMaxAge: This is better understood as the maximum time an image can remain unused before the image become eligible for garbage collection.

It might be better to rename the flag to ImageUnusedThreshold or MaxUnusedTime or similar to be more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Development

No branches or pull requests