New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-plugin callback functions for accurate requeueing in kube-scheduler #4247
Comments
/sig scheduling It was suggested we have a small KEP for QueueingHint. It's kind of a special case though, we can assume DRA is the parent KEP and this KEP stems from it. And I set the alpha version v1.26 which is the same as DRA KEP (or maybe we can just leave it as n/a), and the beta version v1.28 which we actually implemented it and enable it via the beta feature flag (enabled by default).
@kubernetes/sig-scheduling-leads Can anyone give this PR |
Do you have a PR for this already? |
Not yet. Will be ready probably within this weekend. |
Here it is: #4256 |
/label lead-opted-in |
Hello @sanposhiho 👋, v1.29 Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
Hello 👋, 1.29 Enhancements Lead here. /milestone clear |
Hey again 👋 /milestone v1.29 |
Hey there @sanposhiho 👋, v1.29 Docs Lead here. |
So, I submitted the PR for modifying the doc in: @alculquicondor Do you think we need to have a dedicated page or modify some existing pages for QueueingHint? (Or it's OK not to have a doc for QueueingHint as it's internal?) |
I'd like to have a blog post for this enhancement. |
You could also consider a blogpost under https://www.kubernetes.dev/blog |
Any difference between https://kubernetes.io/blog/ and https://www.kubernetes.dev/blog by the way? |
That is correct :) |
Hey again @sanposhiho 👋, 1.29 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs has merged and update in the Issue description: The status of this KEP is Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hi @sanposhiho ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release. It seems from the comment above that this may be the case, please confirm. If so, you need to open a PR placeholder in the website repository. |
Hi, yes, here's the placeholder PR. (empty for now) |
(just noticed I forgot to assign it to me) /assign |
@sanposhiho since the feature was disabled, please update the KEP with notes on what criteria needs to be fulfilled to re-enable the feature. I think the criteria should be roughly:
As a side note, here is the perf dashboard for memory usage https://perf-dash.k8s.io/#/?jobname=gce-5000Nodes&metriccategoryname=E2E&metricname=LoadResources&PodName=kube-scheduler-gce-scale-cluster-master%2Fkube-scheduler&Resource=memory. The test hasn't run since the feature was disabled, so I'm not sure if we will see a memory drop. If we do, then not seeing an increase when the feature is re-enabled would be a good signal. Otherwise, we might need to improve coverage in the load test to incorporate cases with retries. |
It doesn't look like there's an effect in the memory usage according to the dashboard. |
/remove-label lead-opted-in |
@sanposhiho I believe you want to target this release? |
@alculquicondor Yes, let's aim at making it in this release. |
@Huang-Wei could you add the @sanposhiho don't forget to send an update to the KEP with the target version. |
As I'm closing the previous milestone, shall we add milestone v1.30? |
/milestone clear |
yes please, add it |
@Huang-Wei Can you add required labels to this one too, please? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Enhancement Description
k/enhancements
) update PR(s): add(KEP-4247): Per-plugin callback functions for efficient enqueueing in the scheduling queue #4256k/k
) update PR(s): feature(scheduler): implement ClusterEventWithHint to filter out useless events kubernetes#118551k/website
) update(s): ModifySchedulerQueueingHints
website#43427Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: