Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min domains in PodTopologySpread #3022

Open
12 tasks done
sanposhiho opened this issue Oct 28, 2021 · 66 comments
Open
12 tasks done

Min domains in PodTopologySpread #3022

sanposhiho opened this issue Oct 28, 2021 · 66 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 28, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 28, 2021
@sanposhiho
Copy link
Member Author

/sig scheduling
/assign

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 28, 2021
@sanposhiho sanposhiho changed the title Tuning the number of domains in PodTopologySpread Min domains in PodTopologySpread Nov 8, 2021
@ahg-g
Copy link
Member

ahg-g commented Dec 14, 2021

/cc @x13n

@alculquicondor
Copy link
Member

update the description to link to the merged KEP, instead of linking to the PR that added it.

@ahg-g
Copy link
Member

ahg-g commented Jan 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
@Priyankasaggu11929 Priyankasaggu11929 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Hello @sanposhiho 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@PI-Victor
Copy link
Member

Hi @alculquicondor 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Hello @alculquicondor 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@alculquicondor
Copy link
Member

@sanposhiho can you work on the documentation as well?

@sanposhiho
Copy link
Member Author

Sure, I will update doc and kep this weekend.

@alculquicondor
Copy link
Member

There is no need to update the KEP.

@mehabhalodiya
Copy link

@sanposhiho I see already opened up PR: kubernetes/website/pull/32340

@sanposhiho
Copy link
Member Author

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

@mehabhalodiya
Copy link

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

Will you please update the issue description?
Thanks!

@sanposhiho
Copy link
Member Author

@alculquicondor
Isn't the following change for kep needed? (If not needed, I'll close this)
#3245

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 21, 2022

@sanposhiho @alculquicondor, thank you so much.

With the Docs PR kubernetes/website#32340 open now, all requirements for Code Freeze are finished. The status is now tracked.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@ahg-g
Copy link
Member

ahg-g commented Jan 6, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@pnbrown
Copy link

pnbrown commented Feb 5, 2024

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

Thanks for getting the PR merged @sanposhiho.

The milestone is not currently set for this release so this KEP is still At Risk for Enhancements Freeze.

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

Hello 👋, 1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

@salehsedghpour
Copy link
Contributor

/milestone clear

@sanposhiho
Copy link
Member Author

@pnbrown @salehsedghpour
So, if we had had /milestone v1.30 before, this enhancement could be onboard v1.30, correct? If that's the only thing we missed, I believe we consider filing the exception request.

@salehsedghpour
Copy link
Contributor

@sanposhiho you are right. The only thing needed is to have the right milestone.

@alculquicondor
Copy link
Member

Do we really have to submit an exception just for a missing tag?

@salehsedghpour
Copy link
Contributor

@alculquicondor and @sanposhiho as it's only the missing tag, please make sure to add that so that we can mark it as tracked without filing an exception.

@alculquicondor
Copy link
Member

/milestone v1.30

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 9, 2024
@alculquicondor
Copy link
Member

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 9, 2024
@salehsedghpour
Copy link
Contributor

This enhancements is now marked as tracked

@alculquicondor
Copy link
Member

Thank you @salehsedghpour!

@natalisucks
Copy link

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Vyom-Yadav commented Feb 15, 2024

Hello @sanposhiho 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

I don't see any logical changes that might change the explanation docs. But a stability version bumping PR like kubernetes/website#35202 is required, so I'm marking this as Need Docs

@sanposhiho
Copy link
Member Author

@natalisucks As we already wrote the blog when graduating to beta, we don't need a blog this time.

@Vyom-Yadav Got it, here it is: kubernetes/website#45180

@pnbrown
Copy link

pnbrown commented Feb 28, 2024

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@pnbrown
Copy link

pnbrown commented Mar 5, 2024

@sanposhiho, Enhancements team here!
As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented as the code PRs are merged and the feature gates are removed.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/kep.yaml

@sanposhiho
Copy link
Member Author

Sure, #4543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked for Code Freeze
Status: Needs Triage
Development

No branches or pull requests