Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude kubeadm from PRR #3171

Closed
wants to merge 1 commit into from
Closed

exclude kubeadm from PRR #3171

wants to merge 1 commit into from

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jan 21, 2022 •
edited

  • Update the PRR readme with a note that kubeadm is out of scope.
  • Remove existing PRR approvals for kubeadm in
    keps/prod-readiness/sig-cluster-lifecycle. These were rubberstamps and the KEPs do not contain an actual PRR.
  • Update kepval/approval.go to skip kubeadm KEP paths.

some context on why this change is being proposed:
#2067 (comment)

this has been a recurring topic every release

role book PR:
kubernetes/sig-release#1831

@neolit123
exclude kubeadm from PRR
c5b9409 
- Update the PRR readme with a note that kubeadm is out of scope.
- Remove existing PRR approvals for kubeadm in
keps/prod-readiness/sig-cluster-lifecycle.
- Update kepval/approval.go to skip kubeadm KEP paths.
@neolit123 neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neolit123
To complete the pull request process, please assign johnbelamaric after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnbelamaric in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/enhancements Issues or PRs related to the Enhancements subproject label Jan 21, 2022
This was referenced Jan 21, 2022
Closed
Closed
@ehashman
Copy link
Member

PRR team consensus in https://kubernetes.slack.com/archives/CPNHUMN74/p1643393111358089 is that you should still assign a PRR reviewer so that we can confirm kubeadm KEPs are out of scope of PRR.

/close

@k8s-ci-robot
Copy link
Contributor

@ehashman: Closed this PR.

In response to this:

PRR team consensus in https://kubernetes.slack.com/archives/CPNHUMN74/p1643393111358089 is that you should still assign a PRR reviewer so that we can confirm kubeadm KEPs are out of scope of PRR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jan 31, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees
No one assigned
Labels
area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neolit123 @k8s-ci-robot @ehashman