Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Evented PLEG for Better Performance #3386

Open
11 of 22 tasks
harche opened this issue Jun 13, 2022 · 45 comments · Fixed by kubernetes/kubernetes#115967
Open
11 of 22 tasks

Kubelet Evented PLEG for Better Performance #3386

harche opened this issue Jun 13, 2022 · 45 comments · Fixed by kubernetes/kubernetes#115967
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@harche
Copy link
Contributor

harche commented Jun 13, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 13, 2022
@harche
Copy link
Contributor Author

harche commented Jun 13, 2022

/sig-node

@Priyankasaggu11929
Copy link
Member

Hello @harche 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • update the kep.yaml file in the merged KEP to add latest-milestone: "v1.25”

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

@haircommander
Copy link
Contributor

I opened #3410 to target at 1.25

@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 21, 2022
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.25 milestone Jun 21, 2022
@Priyankasaggu11929
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 21, 2022
@Priyankasaggu11929
Copy link
Member

With KEP PR #3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 21, 2022

Hello @haircommander @harche 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

I was able to find the following draft k/k PRs for the KEP:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

@harche
Copy link
Contributor Author

harche commented Jul 22, 2022

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

@harche
Copy link
Contributor Author

harche commented Jul 25, 2022

@Priyankasaggu11929 I just raised a PR - kubernetes/kubernetes#111384

@Priyankasaggu11929
Copy link
Member

Hello @harche 👋

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

@harche
Copy link
Contributor Author

harche commented Aug 2, 2022

API Changes PR - kubernetes/kubernetes#111642

@Priyankasaggu11929
Copy link
Member

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@harche
Copy link
Contributor Author

harche commented Aug 3, 2022

@marosset
Copy link
Contributor

/milestone v1.26
/label lead-opted-in
(I'm doing this on behalf of @ruiwen-zhao / SIG-node)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

@harche: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

Hello @harche, @haircommander, @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@harche
Copy link
Contributor Author

harche commented Feb 7, 2023

Hello @harche, @haircommander, @ruiwen-zhao wave, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@marosset We are aiming to graduate this feature to beta.

@harche
Copy link
Contributor Author

harche commented Feb 9, 2023

@marosset I see that this enhancement has been moved to 1.27 tracking board but the tag on this issue still says tracking/no. Not sure if I am missing something.

@harche
Copy link
Contributor Author

harche commented Feb 9, 2023

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

@marosset
Copy link
Contributor

marosset commented Feb 9, 2023

This enhancement meets all of the requirements to be included in v1.27 and is now tracked for the release.
Thanks @harche !

@marosset marosset added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 9, 2023
@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @harche, @haircommander, @ruiwen-zhao 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@taniaduggal
Copy link

Hi @harche 👋 , I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@harche
Copy link
Contributor Author

harche commented Mar 10, 2023

Thanks @taniaduggal. I have created a PR in k8s/website - kubernetes/website#39913

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@SergeyKanzhelev
Copy link
Member

Wanted to post it here: https://kubernetes.slack.com/archives/C05KQLJEWHX/p1692383024035069

We see from Containerd that events may overflow and not being send to kubelet. Which will lead to wrong results.

Before moving this forward we need to understand how is it happened and whether we see it in other cases. Loosing events will result in bad outcome and hard to troubleshoot bugs

@pacoxu
Copy link
Member

pacoxu commented Dec 21, 2023

I opened kubernetes/kubernetes#122124 to fix the known issue mentioned v1.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Development

Successfully merging a pull request may close this issue.