Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job API managed-by mechanism #4368

Open
4 of 8 tasks
mimowo opened this issue Dec 20, 2023 · 14 comments
Open
4 of 8 tasks

Job API managed-by mechanism #4368

mimowo opened this issue Dec 20, 2023 · 14 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status wg/batch Categorizes an issue or PR as relevant to WG Batch.
Milestone

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 20, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 20, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Dec 20, 2023

/sig apps
/wg batch
/assign

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. wg/batch Categorizes an issue or PR as relevant to WG Batch. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 20, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 19, 2024

/label lead-opted-in
/milestone v1.30
/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 19, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 19, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 19, 2024
@mickeyboxell
Copy link

mickeyboxell commented Jan 31, 2024

Hello @mimowo 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

  • KEP status is marked as implementable for latest-milestone: 1.30.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@mimowo
Copy link
Contributor Author

mimowo commented Feb 1, 2024

@mickeyboxell would you like to take a look at why the checkbox about status: implementable and latest-milestone: 1.30 isn't checked? It seems the fields are filled accordingly in kep.yaml

@mickeyboxell
Copy link

Thanks for catching that. It looks like an oversight on my part.

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@sftim
Copy link
Contributor

sftim commented Feb 13, 2024

BTW, the issue description should link to https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/4368-support-managed-by-label-for-batch-jobs (instead of to #4370)

@celestehorgan
Copy link

@mimowo Can you open a placeholder docs PR for this by Thursday? Thank you 🙏

@mimowo
Copy link
Contributor Author

mimowo commented Feb 14, 2024

@mimowo Can you open a placeholder docs PR for this by Thursday? Thank you 🙏

Sure, PTAL: kubernetes/website#45132.

@natalisucks
Copy link

Hi @mimowo,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@mickeyboxell
Copy link

mickeyboxell commented Feb 22, 2024

Hey again @mimowo 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@mimowo mimowo changed the title Job API managed-by label Job API managed-by mechanism Mar 1, 2024
@kannon92
Copy link
Contributor

kannon92 commented Mar 1, 2024

/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 1, 2024
@mickeyboxell
Copy link

Hi @mimowo 👋 Enhancements team here, just a friendly reminder to follow up on the open Enhancement items above prior to code freeze at 02:00 UTC Wednesday 6th March 2024.

@mickeyboxell
Copy link

Hey again @mimowo 👋 Enhancements team here,

With all the implementation (code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

The last thing to do is to update the status field in the kep.yaml file to implemented when the code PRs are merged and the feature gates are removed.

@mimowo
Copy link
Contributor Author

mimowo commented Mar 6, 2024

@mickeyboxell could you please update the speadsheet to indicate this is Alpha stage: https://github.com/orgs/kubernetes/projects/175/views/1?filterQuery=managed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
Status: Tracked for Doc Freeze
Status: Needs Triage
Development

No branches or pull requests

8 participants